chore: Add coral_web client generation CI step#890
Merged
tianjing-li merged 4 commits intomainfrom Jan 15, 2025
Merged
Conversation
tianjing-li
requested review from
a team,
EugeneLightsOn,
malexw and
scottmx81
as code owners
tianjing-li
had a problem deploying
to
development
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
=======================================
Coverage 76.64% 76.64%
=======================================
Files 259 259
Lines 10583 10583
=======================================
Hits 8111 8111
Misses 2472 2472 ☔ View full report in Codecov by Sentry. |
EugeneLightsOn
approved these changes
Jan 8, 2025
Collaborator
EugeneLightsOn
left a comment
EugeneLightsOn
left a comment
There was a problem hiding this comment.
It's a good idea, Thank you TJ
tianjing-li
changed the title
tianjing-li
changed the title
tianjing-li
had a problem deploying
to
development
GitHub Actions
Failure
tianjing-li
requested review from
BeatrixCohere,
abimacarmes,
knajjars and
tomtobac
as code owners
tianjing-li
had a problem deploying
to
development
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked: waiting on Coral web fixes
AI Description
This pull request introduces several new steps to the workflow, enhancing the build process and ensuring the client is up-to-date.
Generate client, is added to the workflow, which runs the commandnpm run generate:client && npm run format:write. This step generates the client code, ensuring it is up-to-date.Check generated client, is introduced to verify the generated client. It usesgit diff --exit-code ./src/cohere-client/generatedto compare the generated client with the expected version. If they differ, an error message is displayed, prompting regeneration and commitment.